Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename protobuf messages #1214

Merged
merged 6 commits into from
Jun 3, 2022
Merged

Rename protobuf messages #1214

merged 6 commits into from
Jun 3, 2022

Conversation

danieljanes
Copy link
Member

@danieljanes danieljanes commented May 13, 2022

Summary of changes:

  • Change package name in transport.proto from flower.transport to flwr.proto to match the Python package name. This package name will probably change one more time in the future if we decide to move the .proto files into the Python package structure, this change is only there to align the Python and ProtoBuf package names.
  • Use Ins/Res more consistently, e.g., rename GetParameters to GetParametersIns
  • Use imperative naming, e.g., rename ParametersRes to GetParametersRes

@danieljanes danieljanes changed the title Align protobuf messages Rename protobuf messages Jun 1, 2022
@danieljanes danieljanes marked this pull request as ready for review June 1, 2022 09:39
@danieljanes danieljanes requested a review from tanertopal as a code owner June 1, 2022 09:39
tanertopal
tanertopal previously approved these changes Jun 3, 2022
@tanertopal tanertopal merged commit e37d959 into main Jun 3, 2022
@tanertopal tanertopal deleted the protoupdate branch June 3, 2022 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants